Uploaded image for project: 'OpenAM'
  1. OpenAM
  2. OPENAM-10756

setSucessModuleNames in AMLoginModule calls AuthModule's getPrincipal multiple times

    Details

    • Sprint:
      AM Sustaining Sprint 36
    • Story Points:
      1
    • Needs backport:
      No
    • Support Ticket IDs:
    • Verified Version/s:
    • Needs QA verification:
      No
    • Functional tests:
      No
    • Are the reproduction steps defined?:
      Yes and I used the same an in the description

      Description

      It seems with the change in OPENAM-5921 (to 12.0.3 and 13.0.0), the AMLoginModule setSuccessModule have call getPrincipal multiple times

           if (getPrincipal() != null && getPrincipal().getName() != null) {
               loginState.saveAuthenticatedPrincipal(getPrincipal().getName());
           }
      ...
           auditor.auditModuleSuccess(loginState, getPrincipal(), getAuditEntryDetail());
      

      There should be less minimized. Currently this calls to 4 times (and later include on more in commit()).

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                chee-weng.chea C-Weng C
                Reporter:
                chee-weng.chea C-Weng C
                QA Assignee:
                Philip Anderson
              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: