Uploaded image for project: 'OpenAM'
  1. OpenAM
  2. OPENAM-12740

Authentication events update SSO session metrics in addition to authentication session metrics

    Details

    • Target Version/s:
    • Needs backport:
      No
    • Needs QA verification:
      No
    • Functional tests:
      No
    • Are the reproduction steps defined?:
      Yes and I used the same an in the description

      Description

      Bug description

      An unfortunate consequence of client-based and cts-based authentication sessions piggy backing on the implementation of standard sessions is that authentication session events update standard session metrics (in addition to the standard session metrics). For example, when creating a cts-based authentication session both the session.authentication-client-based.create.success and session.client-based.create.success metrics - even though the latter references standard sessions.

      How to reproduce the issue

      Details steps outlining how to recreate the issue (remove this text)

      1. Enable JMX monitoring
      2. Review the current count for session.authentication-client-based.create.success and session.client-based.create.success metrics
      3. Login via an authentication tree
      Expected behaviour
      session.authentication-client-based.create.success count is incremented but session.client-based.create.success count is not.
      
      Current behaviour
      Both session.authentication-client-based.create.success count and session.client-based.create.success count are incremented.
      

      Work around

      N/A.

      Code analysis

      The double accounting is due to MonitoredOperations wrapping DelegatedAuthenticationOperations which wraps MonitoredOperations wrapping StatelessOperations.

        Attachments

          Activity

            People

            • Assignee:
              craig.mcdonnell Craig McDonnell
              Reporter:
              craig.mcdonnell Craig McDonnell
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: