Uploaded image for project: 'OpenAM'
  1. OpenAM
  2. OPENAM-13525

Debug logs for Password Collector node state password is saved in shared state; should be transient state

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 6.0.0, 6.0.0.4
    • Fix Version/s: 6.5.0, 6.0.1
    • Component/s: trees
    • Labels:
    • Rank:
      1|hzwnkf:
    • Sprint:
      AM Sustaining Sprint 54, AM Sustaining Sprint 55
    • Story Points:
      0
    • Needs backport:
      Yes

      Description

      Bug description

      When setting debug level to message and logging in a tree with a password collector node, the authentication logs show the comment: "password has been collected and put in the shared state". It should state instead: "password has been collected and put in the transient state".

      Although it does not have any functional impact, it is misleading and may confuse users. 

      How to reproduce the issue

      1. Install default AM instance
      2. Set debug level to message
      3. Log in using the Example tree: http://openam.example.com:18080/openam/XUI/?service=Example#login 
      4. Open the Authentication debug log
      Expected behaviour
      You should see an entry such as ""password has been collected and put in the transient state""
      Current behaviour
      There is an entry: "password has been collected and put in the shared state""

      Code analysis

      PasswordCollectorNode.java
      logger.debug("password has been collected and put in the shared state");
      return goToNext()
          .replaceSharedState(sharedState.copy())
          .replaceTransientState(transientState.copy().put(PASSWORD, password)).build();
      

        Attachments

          Activity

            People

            Assignee:
            adam.heath Adam Heath
            Reporter:
            nathalie.hoet Nathalie Hoet
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved: