Uploaded image for project: 'OpenAM'
  1. OpenAM
  2. OPENAM-1515

Possibility that LB Cookie is not set

    XMLWordPrintable

    Details

    • Rank:
      1|hznekn:
    • Sprint 3

      Description

      In the IdentityServicesHandler.java, the following dead code is found.

       
          private void setLbCookie(HttpServletRequest request, HttpServletResponse response) {
              if (lbCookieName == null || lbCookieValue == null) {
                  return;
              }
      
              Cookie[] cookies = request.getCookies();
      
              if (cookies != null) {
                  for (int c = 0; c < cookies.length; c++) {
                      cookies[c].getName().equals(lbCookieName); // <- dead code
                      return;
                  }
              }
              
              try {
                  AuthClientUtils.setlbCookie(request, response);
              } catch (Exception ex) {
                  // unable to set lb cookie
              }
          }
      

      Probably, it is a mistake of if statement.

      We need to make sure that there are no problems.

        Attachments

          Issue Links

            Activity

              People

              kohei kohei
              kohei kohei
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved: