Uploaded image for project: 'OpenAM'
  1. OpenAM
  2. OPENAM-16180

Some rules within master.groovy are not idempotent

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 7.0.0
    • Fix Version/s: 7.0.0
    • Component/s: upgrade
    • Labels:

      Description

      Bug description

      Some rules within master.groovy are not idempotent and need to be

      How to reproduce the issue

      Expected behaviour

      Rerunning the rules should result in the same output as running them once.

      Current behaviour

      Unexpected output is encountered when rerunning rules

      Code analysis

      forRealmService("AgentService",
              forInstanceSettings(
                      within("ssoJ2EEAgentConfig",
                              where(key("excludedUserAgentsList").isNotPresent(),
                                      addAttribute("excludedUserAgentsList").with(Collections.emptySet()))))),
      addNewService("DeviceGeoFencingNode"),
      

      In this example the first rule uses a `isNotPresent` to guard against repeat runs.
      The second doesn't.

        Attachments

          Activity

            People

            • Assignee:
              mark.leonard Mark Leonard
              Reporter:
              AndrewVinall Andrew Vinall
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: