Uploaded image for project: 'OpenAM'
  1. OpenAM
  2. OPENAM-17923

Retry Limit Decision Should Not Have User Involvement when Save Retry Limit to User is Disabled

    XMLWordPrintable

Details

    • Rank:
      1|i01bm7:r
    • AM Sustaining Sprint 87, AM Sustaining Sprint 88
    • 5
    • No
    • Yes
    • Yes
    • Yes and I used the same an in the description

    Description

      Bug description

      When user disable Save Retry Limit to User property in Retry Limit Decision node, the behaviour should fall back to original behaviour of not have user involvement.

      How to reproduce the issue

      1. Create the authentication tree as shown in img1.
      2. Set User Profile to Ignored (Realms > [Realm name] > Authentication > Settings > User Profile > User Profile) 
      3. Authenticate with authentication tree
        http://am.example.com:8080/openam?service=tree
      4. Provide user (in this case demo) for both username collector node
      Expected behaviour
      User should redirect to user profile page
      
      Current behaviour
      Login failure
      

       

      Code analysis

      RetryLimitDecisionNode.java
          @Override
          public void onTreeComplete(TreeContext context, boolean success) throws NodeProcessException {
              if (success) {
                  AMIdentity identity = getIdentityFromContext(context);
                  retryStateHandler.clearAttribute(identity);
              }
          }
      
          private AMIdentity getIdentityFromContext(TreeContext context) throws NodeProcessException {
              Optional<AMIdentity> identity = getAMIdentity(context, identityUtils, coreWrapper);
              if (identity.isEmpty()) {
                  logger.warn("identity not found");
                  throw new NodeProcessException("identity.failure");
              }
      
              return identity.get();
          }
      

      Attachments

        Issue Links

          Activity

            People

              chee-weng.chea C-Weng C
              wanning.tan WanNing Tan
              Votes:
              1 Vote for this issue
              Watchers:
              9 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: