Uploaded image for project: 'OpenAM'
  1. OpenAM
  2. OPENAM-17935

Missing 'return' statement in the happy flow of the kerberos node

    XMLWordPrintable

Details

    • AM Sustaining Sprint 87
    • 2

    Description

      Code analysis of the out-of-the-box Kerberos Node reveals that there is a missing 'return' statement in the happy flow of the node:

      release/7.1.0, line 232

      setUserNameAndReturnTrue(usernameAndMaybeUniversalId.getFirst(), usernameAndMaybeUniversalId.getSecond(), newSharedState);

      Therefore a successful login still results in a FAILED outcome.

       

      After adding a 'return' on line 232 and rebuilding the auth-nodes, the happy flow works as expected:

      return setUserNameAndReturnTrue(usernameAndMaybeUniversalId.getFirst(), usernameAndMaybeUniversalId.getSecond(), newSharedState);

      Please incorporate this in the upcoming release(s).

      Attachments

        Activity

          People

            ioannis.sotiropoulos Ioannis Sotiropoulos
            julien.chausse Julien Chausse
            Votes:
            0 Vote for this issue
            Watchers:
            7 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Time Tracking

                Estimated:
                Original Estimate - 16h
                16h
                Remaining:
                Remaining Estimate - 16h
                16h
                Logged:
                Time Spent - Not Specified
                Not Specified