Uploaded image for project: 'OpenDJ'
  1. OpenDJ
  2. OPENDJ-1128

Replication server should not forward heartbeats while holding the domain lock

    Details

    • Type: Bug
    • Status: Done
    • Priority: Major
    • Resolution: Duplicate
    • Affects Version/s: 2.6.0, 2.4.6
    • Fix Version/s: Not applicable
    • Component/s: replication
    • Labels:
      None

      Description

      If a TCP write blocks for some reason (e.g. buffers reduced due to congestion control) then other threads cannot progress.

      The method org.opends.server.replication.server.ReplicationServerDomain.processChangeTimeHeartbeatMsg(ServerHandler, ChangeTimeHeartbeatMsg) forwards HB messages while holding the lock which is risky.

      I think that there are other cases where we write while holding the lock and they should be investigated as well. E.g: org.opends.server.replication.server.ReplicationServerDomain.receiveTopoInfoFromRS(TopologyMsg, ReplicationServerHandler, boolean)

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                matthew Matthew Swift
                Reporter:
                matthew Matthew Swift
                Dev Assignee:
                Matthew Swift
              • Votes:
                0 Vote for this issue
                Watchers:
                0 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: