Uploaded image for project: 'OpenDJ'
  1. OpenDJ
  2. OPENDJ-2327

Improve log message on certain 'Server Error' client disconnects

    Details

    • Type: Improvement
    • Status: Done
    • Priority: Trivial
    • Resolution: Fixed
    • Affects Version/s: 2.6.3
    • Fix Version/s: 3.0.0
    • Component/s: None
    • Support Ticket IDs:

      Description

      Client disconnections like this are quite common to see in the wild:

      [01/Jul/2015:08:43:36 +0000] DISCONNECT conn=23444219 reason="Server Error"
      

      Without any additional 'msg' field filled out it's difficult to tell what these are related to, but my suspicion is that they are usually network related issues, i.e IOException trying to read/write to a client socket.

      If so, 'Server Error' on its own is a bit misleading, as to me this implies some kind of unexpected internal server problem.

      It would be better to have at least something logged in the 'msg' portion of the disconnect so that it's clearer to users what type of problem occurred.

      In fact, it seems there are only a small handful of cases where the msg is not passed in with a SERVER_ERROR, and they all have an associated Exception that could be easily added via getExceptionMessage() or similar.

          catch (Exception e)
          {
            logger.traceException(e);
      
            // FIXME -- Log a message or something
            disconnect(DisconnectReason.SERVER_ERROR, false, null);
            return;
          }
      

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                ian.packer Ian Packer [X] (Inactive)
                Reporter:
                ian.packer Ian Packer [X] (Inactive)
                QA Assignee:
                Christophe Sovant
              • Votes:
                0 Vote for this issue
                Watchers:
                4 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: