Uploaded image for project: 'OpenDJ'
  1. OpenDJ
  2. OPENDJ-5086

Consider refactoring upgrade tool source code

    XMLWordPrintable

    Details

    • Type: Task
    • Status: Done
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 6.0.0
    • Fix Version/s: 6.5.0
    • Component/s: upgrade
    • Labels:
      None

      Description

      As part of the OPENDJ-4736 epic, we might want to cleanup UpgradeTasks.java a bit.
      Suggested points raised so far are:

      • Consider iterating over a Stream<Entry> instead of updating the config file multiple times
      • Simplify the UI management:
        • Instantiating a ProgressNotificationCallback inside the "main" function instead of in each different upgrade tasks (in other words there should be a single new ProgressNotificationCallback())
        • Use simple methods as we do in the setup tool to interact with user (e.g Do you want to ... [yes]?)
          *...

      This issue can be closed when either:

      • We decide to not cleanup the code for any reasons (too long, not enough time...)
      • Refactoring suggested above have been done

        Attachments

          Activity

            People

            Assignee:
            cyril.quinton Cyril Quinton
            Reporter:
            gaetan Gaetan Boismal [X] (Inactive)
            Dev Assignee:
            Cyril Quinton Cyril Quinton
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved: