Uploaded image for project: 'Identity Gateway'
  1. Identity Gateway
  2. OPENIG-4713

We have two JwtValidationContext classes, serving slightly different purposes, which needs to be rationalised

    XMLWordPrintable

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 7.0.0, 7.0.0-micsvc-1.0.3
    • Fix Version/s: 7.0.0, 7.0.0-micsvc-1.0.3
    • Component/s: Core
    • Labels:
      None
    • Sprint:
      2020.10 - IG / Microservices
    • Story Points:
      1

      Description

      Thanks to @Mark dR, I've just noticed that we have two classes named the same:

      • org.forgerock.openig.tools.jwt.JwtValidationContext - Used by CdSsoFilter to propagate across constraints - specifically used in dynamic validation of JWT attributes (i.e. nonce).
      •  org.forgerock.openig.filter.jwt.JwtValidationContext - used by JwtValidationFilter to propagate across constraints.

      Slack conversation
       
      Header comment in both:

      * The validation context that will be passed among the different JWT constraints validations. 
      

      Suggested improvements

      • Rename one to JwtValidatorContext? As it seems we cannot merge them as they have different behavior
      • Rename the builder's context to ValidationContext ?
         

        Attachments

          Activity

            People

            Assignee:
            wayne.morrison Wayne Morrison
            Reporter:
            wayne.morrison Wayne Morrison
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved: