[OPENAM-5986] SPACSUtils incorrectly determines Ignore profile mode Created: 14/May/15  Updated: 01/Jul/15  Resolved: 01/Jul/15

Status: Resolved
Project: OpenAM
Component/s: SAML
Affects Version/s: 10.1.0-Xpress, 11.0.0, 12.0.0, 13.0.0
Fix Version/s: 11.0.4, 12.0.3, 13.0.0

Type: Bug Priority: Major
Reporter: Peter Major [X] (Inactive) Assignee: Mark de Reeper
Resolution: Fixed Votes: 0
Labels: EDISON
Remaining Estimate: 0h
Time Spent: 6h
Original Estimate: 5h

Issue Links:
is related to OPENAM-3470 The SAML2 nameid should not be persis... Resolved
is related to OPENAM-1427 [RFE] support read-only datastore usi... Resolved
Target Version/s:
Sprint: Sprint 82 - Sustaining, Sprint 83 - Sustaining


In SPACSUtils we have the following logic:

ignoreProfile = SAML2Utils.isIgnoreProfileSet(session);

However at that point session is very likely to be null, hence the ignoreProfile mode is determined incorrectly (will be false for null sessions).

To reproduce this:

  • enable Ignore profile at the SP
  • configure the SP to do auto-federation
  • initiate SAML authentication using a non-persistent, non-transient NameID-Format

The usage of auto-federation is key in reproducing this issue, because local authentication based account linking will mean that the session is non-null when accessing the SAML endpoint.

Comment by Mark de Reeper [ 26/May/15 ]

Rather than getting this info from the Session object which might be null, looking at getting it from the config for the realm.

Comment by Mark de Reeper [ 01/Jul/15 ]

Fixed in r14469, r14470 and r14471.

Generated at Wed Nov 25 04:58:20 UTC 2020 using Jira 7.13.12#713012-sha1:6e07c38070d5191bbf7353952ed38f111754533a.