[OPENDJ-3711] Cancellation of requests should be moved out of client connection Created: 03/Feb/17  Updated: 07/Nov/19  Resolved: 25/Aug/17

Status: Done
Project: OpenDJ
Component/s: core server, proxy
Affects Version/s: 4.0.0
Fix Version/s: 5.5.0

Type: Task Priority: Major
Reporter: Nicolas Capponi Assignee: Yannick Lecaillez
Resolution: Fixed Votes: 0
Labels: None

Issue Links:
Depends
is required by OPENDJ-3998 Remove ClientConnection and sub-classes Done
Relates
relates to OPENDJ-3868 Proxied persistent searches are not c... Done
relates to OPENDJ-3593 Remove deprecated RequestHandler, Ser... Done
is related to OPENDJ-4225 RequestHandle must support aggregation Done
Dev Assignee: Yannick Lecaillez

 Description   

Cancellation of request is still done at the client connection level, i.e. in LdapClientConnection and HTTPClientConnection.
It should be moved out of these classes and done at the upper level, because sending the response can now be called several times for a subordinate search (it was called only once previously). In effect cancellation it not possible any more after the response from the first backend has been sent.



 Comments   
Comment by Matthew Swift [ 03/Feb/17 ]

Issue OPENDJ-3593 will introduce APIs facilitating support for cancel/abandon requests. I suggest that I take this issue and work on it post OPENDJ-3593.

Comment by Matthew Swift [ 03/Feb/17 ]

The fix for this change should ensure that client disconnects, abandon requests, and cancel requests are correctly propagated through to any active proxied requests. A concrete use case is where a client disconnects having performed some proxied persistent searches. These MUST be aborted to avoid resource leaks.

Comment by Matthew Swift [ 10/Mar/17 ]

Ludovic Poitou - ping - we need to decide whether we want to support psearches or not in 4.0.0.

Comment by Ludovic Poitou [ 10/Mar/17 ]

Psearches are used by AM. If we don't support them, it means customers cannot use the Proxy with AM.
How much time do you estimate it will take to had support for cancelling operations ?
Just estimating if this is something we can do right after the release as a patch / maintenance release or customers will have to wait for at least 6 months.

Comment by Matthew Swift [ 10/Mar/17 ]

We'll need to migrate the SDK from Promises to Rx, so it's quite a big job and not one we can deliver in a patch, unless we can think of a short term workaround.

Comment by Matthew Swift [ 15/Mar/17 ]

The decision is that we will mention in the release notes that proxied psearches are not supported for OpenDJ 4.0.

Bug OPENDJ-3868 should be used in the release notes to track the lack of support for psearches.

Comment by Matthew Swift [ 07/Nov/19 ]

Moved to closed state because the fixVersion has already been released.

Generated at Tue Oct 27 06:38:47 UTC 2020 using Jira 7.13.12#713012-sha1:6e07c38070d5191bbf7353952ed38f111754533a.