[OPENIG-3221] OpenIG is decoding special character ' while sending to the backend which is causing issues Created: 01/Nov/18  Updated: 19/Aug/20  Resolved: 29/Mar/19

Status: Closed
Project: Identity Gateway
Component/s: None
Affects Version/s: 5.5.0
Fix Version/s: 7.0.0-micsvc-1.0.0, 7.0.0

Type: Bug Priority: Critical
Reporter: James Dewer Assignee: Guillaume Sauthier
Resolution: Fixed Votes: 0
Labels: release-notes
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Backport
is backported by OPENIG-3572 Backport OPENIG-3221: OpenIG is decod... Resolved
Depends
depends on CHF-199 Preserve Query string Resolved
Document
is documented by OPENIG-3571 Doc: OpenIG is decoding special chara... Resolved
Relates
relates to OPENIG-947 OpenIG 4.0 does not preserve query st... Resolved
Test
Support Ticket IDs:
Epic Link: 7.0 - Stability
Sprint: OpenIG Sprint 138 (7.0 init), OpenIG Sprint 139, OpenIG Sprint 141, 2019.5 - OpenIG
Story Points: 3

 Description   

OpenIG is decoding special character ' while sending to the backend which can cause issues:

 

https://www.test.example.com/en/personal/?a=%27test

When passing this URL in the browser , at tomcat level the URL is properly carried to the IG as below :

TOMCAT Logs :

"GET /en/personal/?a=%27test HTTP/1.1" 400 - "Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/68.0.3440.84 Safari/537.36" "-" - 0.009 - -

In the route Log of OpenIG :

GET http://localhost:10015/en/person*al/?a='test* HTTP/1.1

 

In the above URL %27 is decoded to ' and is being transferred to the backend which is causing issues with all the URLS which have an accented character in it.



 Comments   
Comment by Guillaume Sauthier [ 05/Nov/18 ]

It looks like this incoming URL sanitization was done for CREST initially, maybe a solution would be to have a new filter, used only within the CREST adaptation layer.

So any URLs going through CHF are left un-touched, while CREST requests are sanitized to be CREST friendly.

That said, this is having a large impact on all the products, so would need a bit of testing, discussion with the product teams.

And definitely not something we can do for 6.5

Comment by Joanne Henry [ 05/Nov/18 ]

Guillaume Sauthier, currently not flagged for RN. To include?

Comment by Guillaume Sauthier [ 05/Nov/18 ]

I think so

Comment by Guillaume Sauthier [ 26/Mar/19 ]

Same issue: CHF does not preserve query string, trying to fix invalid chars with too much side effects.

Comment by Jean-Charles Deville [ 19/Aug/20 ]

Closing issue after Release 7.0.0

Generated at Fri Sep 25 23:39:09 UTC 2020 using Jira 7.13.12#713012-sha1:6e07c38070d5191bbf7353952ed38f111754533a.