[OPENIDM-5997] Invalid "lastSync" JSON schema syntax in managed.json Created: 13/Jun/16  Updated: 10/Nov/16  Resolved: 10/Nov/16

Status: Closed
Project: OpenIDM
Component/s: Module - Core mapping, synchronization, reconciliation, Module - Roles
Affects Version/s: OpenIDM 4.5.0
Fix Version/s: OpenIDM 5.0.0

Type: Bug Priority: Minor
Reporter: Travis Haagen Assignee: Travis Haagen
Resolution: Fixed Votes: 0
Labels: release-notes
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Relates
relates to OPENIDM-6313 Editing managed user schema from admi... Closed
Verified Version/s:

 Description   

managed.json (all occurrences of this file) has some invalid JSON Schema syntax where "items" : "object" should be changed to "items" : { "type" : "object" }

managed.json
                    "lastSync" : {
                        "type" : "object",
                        "scope" : "private",
                        "viewable" : false,
                        "searchable" : false,
                        "properties" : {
                            "effectiveAssignments" : {
                                "type" : "array",
                                "items" : "object"
                            },
                            "timestamp" : {
                                "type" : "string"
                            }
                        }
                    }

It should be changed to the following, and the underlying functionality re-tested,

managed.json
                    "lastSync" : {
                        "type" : "object",
                        "scope" : "private",
                        "viewable" : false,
                        "searchable" : false,
                        "properties" : {
                            "effectiveAssignments" : {
                                "type" : "array",
                                "items" : {
                                    "type" : "object"
                                }
                            },
                            "timestamp" : {
                                "type" : "string"
                            }
                        }
                    }

Reference: https://spacetelescope.github.io/understanding-json-schema/reference/array.html#items



 Comments   
Comment by Laurent Bristiel [ 14/Jun/16 ]

Alin Brici I think you are the one who worked on this lastSync. Do you confirm we have a schema issue here? Though from the tests I did, the whole "feature" was working fine. Should we fix that (and test it of course) in the 4.5 branch in addition to master?

Comment by Travis Haagen [ 16/Jun/16 ]

QA: please test that this JSON patch is applied during an open-idm update

Comment by Laurent Bristiel [ 17/Jun/16 ]

checked OK on OpenIDM version "5.0.0-SNAPSHOT" (revision: 4cc360e)
Upgrade will be checked later on, when the update tool is ready/mature (we will compare a from scratch config with an updated one)

Comment by Lana Frost [ 10/Nov/16 ]

Reopening to add to Release Notes

Generated at Tue Oct 16 22:06:46 BST 2018 using JIRA 7.3.8#73019-sha1:94e8771b8094eef96c119ec22b8e8868d286fa88.